Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST validate check statement only in while/for loops #111

Merged
merged 4 commits into from
Nov 12, 2024
Merged

AST validate check statement only in while/for loops #111

merged 4 commits into from
Nov 12, 2024

Conversation

ferranbt
Copy link
Contributor

@ferranbt ferranbt commented Nov 11, 2024 •
edited
Loading

This PR extends the AstValidator to check that break statements can only happen while in for or while statements.

DaniPopes
DaniPopes requested changes Nov 11, 2024
View reviewed changes
tests/ui/parser/break_outside_loop.sol Outdated Show resolved Hide resolved
tests/ui/parser/break_outside_loop.sol Outdated Show resolved Hide resolved
crates/sema/src/ast_passes.rs Show resolved Hide resolved
crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
@ferranbt ferranbt force-pushed the ferranbt/ast-check-break-stmt branch from 8227a2e to b667fb2 Compare November 11, 2024 18:36
DaniPopes
DaniPopes approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DaniPopes DaniPopes merged commit b830214 into paradigmxyz:main Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferranbt @DaniPopes